Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trim trailing slash from Gitea URL #3488

Merged
merged 3 commits into from Oct 22, 2022

Conversation

SamTherapy
Copy link
Contributor

This PR will truncate any trailing slash left by specifying only a Gitea API URL.

Fixes #3487

I have not added any tests for this.

Fixes goreleaser#3487

Signed-off-by: Sam Therapy <sam@samtherapy.net>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2022
@SamTherapy
Copy link
Contributor Author

SamTherapy commented Oct 21, 2022

Strange, this did not fail when I tested it locally using task test

Thank you!

Co-authored-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Sam Therapy <sam@samtherapy.net>
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #3488 (303cf05) into main (f28a70c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3488   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         114      114           
  Lines        9297     9297           
=======================================
  Hits         7832     7832           
  Misses       1189     1189           
  Partials      276      276           
Impacted Files Coverage Δ
internal/pipe/defaults/defaults.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 154c520 into goreleaser:main Oct 22, 2022
@github-actions github-actions bot added this to the v1.13.0 milestone Oct 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitea Publish URL contains an extra /
2 participants