Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoop pipeline doesn't substitute variables #3508

Closed
3 tasks done
aymanbagabas opened this issue Oct 29, 2022 · 2 comments · Fixed by #3521
Closed
3 tasks done

Scoop pipeline doesn't substitute variables #3508

aymanbagabas opened this issue Oct 29, 2022 · 2 comments · Fixed by #3521
Assignees
@caarlos0
Labels
bug Something isn't working good-first-issue
Milestone
v1.13.0

Comments

@aymanbagabas
Copy link

aymanbagabas commented Oct 29, 2022 •
edited

What happened?

The Scoop pipeline does not replace custom variables defined in the YAML.

How can we reproduce this?

variables:
  owner: foo
  author: My Name
  email: email@example.com
scoop:
  bucket:
    owner: '{{ .Var.owner }}'
    name: scoop-bucket
    token: "{{ .Env.TOKEN }}"
  commit_author:
    name: '{{ .Var.author }}'
    email: '{{ .Var.email }}'
  license: MIT

This results in

    • scoop manifests
      • error checking for default branch            err=GET https://api.github.com/repos/%7B%7B%20.Var.owner%20%7D%7D/scoop-bucket: 404 Not Found [] projectID={{ .Var.owner }}/scoop-bucket statusCode=404
      • error checking for default branch, using master err=GET https://api.github.com/repos/%7B%7B%20.Var.owner%20%7D%7D/scoop-bucket: 404 Not Found [] fileName=vhs.json projectID={{ .Var.owner }}/scoop-bucket requestedBranch=

goreleaser version

goreleaser v1.12.3-pro

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

https://github.com/charmbracelet/vhs/actions/runs/3348068776/jobs/5547309678
@aymanbagabas aymanbagabas added bug Something isn't working triage Issue pending triage by one of the maintainers labels Oct 29, 2022
@caarlos0 caarlos0 added good-first-issue and removed triage Issue pending triage by one of the maintainers labels Oct 29, 2022
@caarlos0 caarlos0 added this to the v1.13.0 milestone Oct 29, 2022
@caarlos0 caarlos0 mentioned this issue Nov 2, 2022
Merged
@caarlos0
Copy link
Member

caarlos0 commented Nov 2, 2022

see #3521

caarlos0 added a commit that referenced this issue Nov 2, 2022
@caarlos0
fix: allow to template scoop/brew/krew repo ref (#3521)
1a69d44 
closes #3508

- adds template support for krew and scoop repo refs
- template branch on reporef on brew as well

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working good-first-issue
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

fix: allow to template scoop/brew/krew repo ref goreleaser/goreleaser
2 participants
@caarlos0 @aymanbagabas