fix(changelog): group regexps #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
stevenh
force-pushed
the
fix/changelog-regexps
branch
from
5a9a565
to
708f44f
Compare
caarlos0
reviewed
Nov 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
+ Coverage 84.26% 84.27% +0.01%
==========================================
Files 114 114
Lines 9329 9338 +9
==========================================
+ Hits 7861 7870 +9
Misses 1191 1191
Partials 277 277
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pull-request-size
bot
added
size/M
stevenh
force-pushed
the
fix/changelog-regexps
branch
from
e1f063d
to
079b5bd
Compare
|
Had to roll back some changes which worked with the tests but didn't work in practice on github which has different output. I went with a conservative non greedy |
stevenh
force-pushed
the
fix/changelog-regexps
branch
from
079b5bd
to
01bbd38
Compare
Fix the regular expressions used in changelog group processing to valid golang (RE2) regexps. These previously used PCRE character class \w which is not supported in RE2 which is what golang regexp uses. Document that format matches not just title as some may thing but the format "<abbrev-commit> <title-commit>". This also include "!" as defined by conventional commits.
Note changelog group regexp parameters are in RE2 syntax.
Use [[:xdigit:]] to match the abbrev-commit, which is clearer as to the intent and correct as the previous version had a typo anyway.
GitHub has different output than the tests, including a colon after the commit reference, so make the pattern resilient to that and other nuisances by making it a full wild card but non greedy. Also: * Remove processed entries instead of striking them out, allowing early exit when we're done. * Add group match debugging to users can see what's going on with --debug.
Fix invalid invalid index access in changelog processing when removing processed items.
stevenh
force-pushed
the
fix/changelog-regexps
branch
from
dd73294
to
ffe9559
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regular expressions used in changelog group processing to valid golang (RE2) regexps. These previously used PCRE character class
\wwhich is not supported in RE2 which is what golang regexp uses.Also document that format matches not just title as some may thing but the format
<abbrev-commit> <title-commit>.