Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve github release code #3547

Merged
merged 2 commits into from Nov 18, 2022
Merged

fix: improve github release code #3547

merged 2 commits into from Nov 18, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 12, 2022 •
edited

It makes no sense, but I saw it happens some times... the release will be created as a draft, even though there's nothing telling it to do so.

Editing the release later might do the trick, hopefully.

closes #3541

@caarlos0 caarlos0 self-assigned this Nov 12, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2022
@vercel vercel bot temporarily deployed to Preview November 12, 2022 20:22 Inactive
@caarlos0 caarlos0 added the bug Something isn't working label Nov 12, 2022
@caarlos0 caarlos0 added this to the v1.13.0 milestone Nov 12, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 12, 2022 20:23
@vercel vercel bot temporarily deployed to Preview November 12, 2022 20:24 Inactive
@vercel vercel bot temporarily deployed to Preview November 12, 2022 20:59 Inactive
@caarlos0
fix: improve github release code
444c039 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0
chore: fmt
19cf98c
@vercel vercel bot temporarily deployed to Preview November 12, 2022 21:00 Inactive
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited

Codecov Report

Merging #3547 (bef79c1) into main (e1ab104) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head bef79c1 differs from pull request most recent head 19cf98c. Consider uploading reports for the commit 19cf98c to get more accurate results

@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   83.64%   83.54%   -0.10%     
==========================================
  Files         116      116              
  Lines        9692     9702      +10     
==========================================
- Hits         8107     8106       -1     
- Misses       1284     1295      +11     
  Partials      301      301
Impacted Files Coverage Δ
internal/client/github.go 30.98% <0.00%> (-1.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 5731815 into main Nov 18, 2022
@caarlos0 caarlos0 deleted the github-release branch November 18, 2022 01:57
@caarlos0 caarlos0 mentioned this pull request Nov 18, 2022
Closed
3 tasks
caarlos0 added a commit that referenced this pull request Nov 18, 2022
@caarlos0
revert: unneeded release update
78fa66a 
refs #3541
refs #3547

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

[PRO] Nightly stopped publishing releases
1 participant
@caarlos0