Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set file info for binaries inside archives #3618

Merged
merged 4 commits into from Dec 14, 2022
Merged

feat: set file info for binaries inside archives #3618

merged 4 commits into from Dec 14, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 3, 2022 •
edited

closes #3582

@caarlos0
feat: set file info for binaries inside archives
c0e5add 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Dec 3, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 3, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 3, 2022
@caarlos0 caarlos0 marked this pull request as ready for review December 3, 2022 01:35
@vercel vercel bot temporarily deployed to Preview December 3, 2022 01:35 Inactive
@caarlos0 caarlos0 mentioned this pull request Dec 3, 2022
Closed
2 tasks
@vercel vercel bot temporarily deployed to Preview December 3, 2022 01:40 Inactive
@codecov
Copy link

codecov bot commented Dec 3, 2022 •
edited

Codecov Report

Merging #3618 (381a11b) into main (dae543f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3618   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files         117      117           
  Lines        9839     9840    +1     
=======================================
+ Hits         8229     8230    +1     
  Misses       1299     1299           
  Partials      311      311
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/pipe/archive/archive.go 92.79% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vercel vercel bot temporarily deployed to Preview December 10, 2022 15:45 Inactive
ranoch
ranoch reviewed Dec 11, 2022
View reviewed changes
Copy link

@ranoch ranoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3582

@caarlos0 caarlos0 mentioned this pull request Dec 11, 2022
Merged
@myitcv myitcv mentioned this pull request Dec 12, 2022
Closed
@caarlos0 caarlos0 merged commit 9370676 into main Dec 14, 2022
@caarlos0 caarlos0 deleted the info branch December 14, 2022 15:16
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 14, 2022
caarlos0 added a commit that referenced this pull request Dec 14, 2022
@caarlos0
feat: allow to template archives.files.info (#3630)
2e5a8e5 
this allows to template the owner, group and mtime in file infos inside
archives.

should help towards reproducible builds!

goes well with #3618

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranoch ranoch ranoch left review comments

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

support creating a reproducible tar archive
2 participants
@caarlos0 @ranoch