Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improving minio and docker tests #3642

Merged
merged 9 commits into from Dec 15, 2022
Merged

feat: improving minio and docker tests #3642

merged 9 commits into from Dec 15, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 14, 2022

using ory/dockertest to simplify integration tests

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Dec 14, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2022
@vercel vercel bot temporarily deployed to Preview December 14, 2022 02:19 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 14, 2022
@caarlos0 caarlos0 marked this pull request as ready for review December 14, 2022 02:20
@vercel vercel bot temporarily deployed to Preview December 14, 2022 02:20 Inactive
@caarlos0 caarlos0 changed the title feat: improving minio tests feat: improving minio and docker tests Dec 14, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #3642 (521e9cb) into main (583bca5) will decrease coverage by 0.07%.
The diff coverage is 41.17%.

❗ Current head 521e9cb differs from pull request most recent head 719a8fe. Consider uploading reports for the commit 719a8fe to get more accurate results

@@            Coverage Diff             @@
##             main    #3642      +/-   ##
==========================================
- Coverage   83.63%   83.56%   -0.08%     
==========================================
  Files         117      118       +1     
  Lines        9839     9856      +17     
==========================================
+ Hits         8229     8236       +7     
- Misses       1299     1306       +7     
- Partials      311      314       +3     
Impacted Files Coverage Δ
internal/testlib/docker.go 41.17% <41.17%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vercel vercel bot temporarily deployed to Preview December 14, 2022 02:31 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview December 14, 2022 02:36 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview December 14, 2022 02:55 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview December 14, 2022 03:07 Inactive
@vercel vercel bot temporarily deployed to Preview December 14, 2022 03:08 Inactive
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview December 14, 2022 03:30 Inactive
@vercel vercel bot temporarily deployed to Preview December 14, 2022 15:09 Inactive
@caarlos0 caarlos0 merged commit 0767ded into main Dec 15, 2022
@caarlos0 caarlos0 deleted the minio branch December 15, 2022 13:25
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant