Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only fail announcing phase in the end #3666

Merged
merged 3 commits into from Dec 28, 2022
Merged

fix: only fail announcing phase in the end #3666

merged 3 commits into from Dec 28, 2022

Conversation

caarlos0
Copy link
Member

This prevents one announce failure to skip all other announcers.

The release will still report a failure in the end, but will not fail in the first failure.

Also improved errors messages a little bit.

closes #3663

This prevents one announce failure to skip all other announcers.

The release will still report a failure in the end, but will not fail in
the first failure.

Also improved errors messages a little bit.

closes #3663

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Dec 28, 2022
@caarlos0 caarlos0 self-assigned this Dec 28, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 28, 2022
@vercel
Copy link

vercel bot commented Dec 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
goreleaser 🔄 Building (Inspect) Dec 28, 2022 at 2:07PM (UTC)

@vercel vercel bot temporarily deployed to Preview December 28, 2022 14:07 Inactive
@vercel vercel bot temporarily deployed to Preview December 28, 2022 14:12 Inactive
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #3666 (df23247) into main (1d2842c) will increase coverage by 0.02%.
The diff coverage is 62.33%.

@@            Coverage Diff             @@
##             main    #3666      +/-   ##
==========================================
+ Coverage   83.58%   83.60%   +0.02%     
==========================================
  Files         118      118              
  Lines        9912     9926      +14     
==========================================
+ Hits         8285     8299      +14     
  Misses       1311     1311              
  Partials      316      316              
Impacted Files Coverage Δ
internal/pipe/smtp/smtp.go 19.60% <0.00%> (ø)
internal/pipe/webhook/webhook.go 72.36% <37.50%> (ø)
internal/pipe/discord/discord.go 50.00% <40.00%> (ø)
internal/pipe/mattermost/mattermost.go 79.45% <40.00%> (ø)
internal/pipe/teams/teams.go 52.00% <40.00%> (ø)
internal/pipe/linkedin/linkedin.go 53.33% <50.00%> (ø)
internal/pipe/reddit/reddit.go 70.73% <50.00%> (ø)
internal/pipe/telegram/telegram.go 55.17% <50.00%> (ø)
internal/pipe/mastodon/mastodon.go 54.83% <66.66%> (ø)
internal/pipe/twitter/twitter.go 66.66% <66.66%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 47ce9a9 into main Dec 28, 2022
@caarlos0 caarlos0 deleted the ann-err-hand branch December 28, 2022 15:24
@caarlos0 caarlos0 added this to the v1.15.0 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle announce failures better
1 participant