fix(gitlab): correctly prepend/append/keep releases notes #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
I guess typo github -> gitlab Ahh good catch, thanks for the PR! |
|
@caarlos0 ahhh, yes. GitLab, of course. |
Codecov Report
@@ Coverage Diff @@
## main #3765 +/- ##
==========================================
+ Coverage 83.65% 83.75% +0.09%
==========================================
Files 119 119
Lines 10217 10217
==========================================
+ Hits 8547 8557 +10
+ Misses 1343 1332 -11
- Partials 327 328 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found a bug in the GitLab client that leads to not correctly prepend/append/keep releases notes.
This will use the original
Descriptioninstead of the pre-renderedDescriptionHTML. Furthermore, asinclude_html_descriptionis not enabled, theDescriptionHTMLfield is always empty.GitLab documentation