Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonschema): add binary to Archive format enum #3924

Merged

Conversation

maxbrunet
Copy link
Contributor

Add binary to Archive format enum in the JSON schema.

JSON schema validation currently fails on archives[0].format: binary:

Value is not accepted. Valid values: "tar", "tgz", "tar.gz", "zip", "gz", "tar.xz", "txz".

Follow up to c41d6de

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #3924 (76f1cf4) into main (13d3771) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3924   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         124      124           
  Lines       10954    10954           
=======================================
  Hits         9152     9152           
  Misses       1445     1445           
  Partials      357      357           
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit b36e30a into goreleaser:main Apr 11, 2023
11 checks passed
@caarlos0
Copy link
Member

Ahh, right! Thanks!

@caarlos0 caarlos0 added the bug Something isn't working label Apr 11, 2023
@caarlos0 caarlos0 added this to the v1.18.0 milestone Apr 11, 2023
@maxbrunet maxbrunet deleted the fix/jsonschema/archive-format-binary branch April 11, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants