fix: source archive not being added when no extra-files #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #3937 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/L
Deploying with
|
| Latest commit: |
4a98220
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d5e5dbd.goreleaser.pages.dev |
| Branch Preview URL: | https://fix-src.goreleaser.pages.dev |
caarlos0
commented
Apr 13, 2023
Comment on lines
-95
to
-98
| // zips wont have the parent dir | ||
| if format == "zip" { | ||
| expected = expected[1:] | ||
| } |
There was a problem hiding this comment.
this was actually another bug, fixed it too
Codecov Report
@@ Coverage Diff @@
## main #3938 +/- ##
==========================================
+ Coverage 83.54% 83.58% +0.03%
==========================================
Files 124 124
Lines 10954 10958 +4
==========================================
+ Hits 9152 9159 +7
+ Misses 1445 1443 -2
+ Partials 357 356 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3937