fix(nfpm): Add extension to produced artifacts

[mbamber]

Add extension to produced artifacts so that they can be filtered in later steps

Fixes #3933

---

I tried running the tests before raising this, but I get an unrelated error with docker (I get the same error on main). I'm not sure about if you value a test specifically around this? If so, lmk and I'll try to add one

[caarlos0]

looks good, should probably add a test too.

This should suffice:

diff --git a/internal/pipe/nfpm/nfpm_test.go b/internal/pipe/nfpm/nfpm_test.go
index 21e23af1..57809ae8 100644
--- a/internal/pipe/nfpm/nfpm_test.go
+++ b/internal/pipe/nfpm/nfpm_test.go
@@ -281,6 +281,7 @@ func TestRunPipe(t *testing.T) {
 	for _, pkg := range packages {
 		format := pkg.Format()
 		require.NotEmpty(t, format)
+		require.Equal(t, pkg.Format(), artifact.ExtraOr(*pkg, artifact.ExtraExt, ""))
 		arch := pkg.Goarch
 		if pkg.Goarm != "" {
 			arch += "v" + pkg.Goarm

[caarlos0]

awesome, thank you!

[caarlos0]

I tried running the tests before raising this, but I get an unrelated error with docker (I get the same error on main). I'm not sure about if you value a test specifically around this? If so, lmk and I'll try to add one

hmmm which error you got? may be worth investigating...

[mbamber]

TestRunPipe/multiarch_image_template_error_on_docker

Output:

--- FAIL: TestRunPipe (7.34s)
    docker_test.go:959: starting registries
    --- FAIL: TestRunPipe/multiarch_image_template_error_on_docker (3.74s)
        docker_test.go:1051:
            	Error Trace:	/Users/mbamber/workspace/goreleaser/internal/pipe/docker/docker_test.go:47
            	            				/Users/mbamber/workspace/goreleaser/internal/pipe/docker/docker_test.go:1051
            	Error:      	Received unexpected error:
            	            	docker build failed: seems like you tried to copy a file that is not available in the build context.

            	            	Here's more information about the build context:

            	            	dir: "/var/folders/z6/04q0xsdn4zl1kzsxg0tsv7c00000gn/T/goreleaserdocker3348068017"
            	            	files in that dir:
            	            	 Dockerfile
            	            	 anotherbin
            	            	 mybin
            	            	 mybin_arm64.apk

            	            	Previous error:
            	            	failed to build localhost:5050/goreleaser/test_multiarch_img_tmpl_error: exit status 1: #1 [internal] load build definition from Dockerfile
            	            	#1 sha256:197467af2f316b7d03019b38c72600fb2c0dc25b796613e94ef25062c2d96fce
            	            	#1 transferring dockerfile: 66B 0.0s done
            	            	#1 DONE 0.1s

            	            	#2 [internal] load .dockerignore
            	            	#2 sha256:66f38a7631a43183fcc0a8f02571c83154a9049da86edeeddf37de0fb3f74bae
            	            	#2 transferring context: 2B done
            	            	#2 DONE 0.1s

            	            	#3 [internal] load metadata for docker.io/library/alpine:latest
            	            	#3 sha256:d4fb25f5b5c00defc20ce26f2efc4e288de8834ed5aa59dff877b495ba88fda6
            	            	#3 ERROR: rpc error: code = Unknown desc = error getting credentials - err: exec: "docker-credential-desktop": executable file not found in $PATH, out: ``
            	            	------
            	            	 > [internal] load metadata for docker.io/library/alpine:latest:
            	            	------
            	            	failed to solve with frontend dockerfile.v0: failed to create LLB definition: rpc error: code = Unknown desc = error getting credentials - err: exec: "docker-credential-desktop": executable file not found in $PATH, out: ``

            	            	Learn more at https://goreleaser.com/errors/docker-build
            	Test:       	TestRunPipe/multiarch_image_template_error_on_docker
FAIL

Having spent more than 5s actually reading this error, it's probably because I don't have docker-credential-desktop installed/setup correctly, so I reckon this is a non-issue

[caarlos0]

err: exec: "docker-credential-desktop": executable file not found in $PATH, out:

this seems to be the root cause...

[caarlos0]

this should improve it: #3942

[mbamber]

Awesome! Thanks!