fix: do not fatal on automaxprocs error #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying with
|
| Latest commit: |
dd346b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb6adeed.goreleaser.pages.dev |
| Branch Preview URL: | https://wsl.goreleaser.pages.dev |
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #3946 +/- ##
==========================================
- Coverage 83.57% 83.56% -0.01%
==========================================
Files 124 124
Lines 10970 10971 +1
==========================================
Hits 9168 9168
- Misses 1445 1446 +1
Partials 357 357
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fail on windows/wsl (see uber-go/automaxprocs#65), and its not too bad if it fails, actually, so, let's just warn the error instead of exiting 1
closes #3945
Signed-off-by: Carlos Alexandro Becker caarlos0@users.noreply.github.com