Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix doesn't work with format=zip #4224

Closed
Tracked by #4034
caarlos0 opened this issue Aug 2, 2023 · 6 comments · Fixed by #4225
Closed
Tracked by #4034

nix doesn't work with format=zip #4224

caarlos0 opened this issue Aug 2, 2023 · 6 comments · Fixed by #4225
Assignees
@caarlos0
Labels
bug Something isn't working
Milestone
v1.23.0

Comments

@caarlos0
Copy link
Member

caarlos0 commented Aug 2, 2023 •
edited

zip support; having format: zip results in do not know how to unpack source archive /nix/store/dvl2hd8i63dq4xw76l49l1is6i3yh0nk-blah_0.0.1_darwin_all.zip
@caarlos0 caarlos0 mentioned this issue Aug 2, 2023
Closed
8 tasks
caarlos0 added a commit that referenced this issue Aug 2, 2023
@caarlos0
feat(nix): support zip packages
dd3cf83 
closes #4224
@caarlos0 caarlos0 mentioned this issue Aug 2, 2023
Merged
caarlos0 added a commit that referenced this issue Aug 2, 2023
@caarlos0
feat(nix): support zip packages (#4225)
c6655bc 
closes #4224
@caarlos0 caarlos0 changed the title zip support; having format: zip results in do not know how to unpack source archive /nix/store/dvl2hd8i63dq4xw76l49l1is6i3yh0nk-blah_0.0.1_darwin_all.zip nix doesn't work with format=zip Aug 2, 2023
@lionello
Copy link
Contributor

lionello commented Aug 3, 2023 •
edited

Hey @caarlos0 I think you'd want to add it to inputs, not dependencies, no? It's basically the same as makeWrapper. Oh you added to both inputs and dependencies, so that's fine. (Why though?)

@caarlos0
Copy link
Member Author

caarlos0 commented Aug 3, 2023

@lionello Its how I saw other packages doing it in nixpkgs... is it wrong?

@lionello
Copy link
Contributor

lionello commented Aug 3, 2023 •
edited

I think it's not necessary to add to dependencies, but it wouldn't hurt either.

@lionello
Copy link
Contributor

@caarlos0 I don't think this is fixed, since the Nix files generated with v1.22.1 are still missing the unzip dependency.

See https://github.com/defang-io/defang/actions/runs/7283416033/job/19847250711#step:6:16 and the generated file https://github.com/defang-io/defang/blob/f9d759d961baf6c0baf53e28402fdc71f04ad8b3/pkgs/defang/default.nix

@caarlos0
Copy link
Member Author

ah, different case, URLs mixing formats... will fix, thanks for reporting 🙏

caarlos0 added a commit that referenced this issue Dec 21, 2023
@caarlos0
fix(nix): include unzip if any artifact is a zip
c17292b 
Instead of just the first one.

refs #4224
@caarlos0 caarlos0 mentioned this issue Dec 21, 2023
Merged
@caarlos0
Copy link
Member Author

see #4495

@caarlos0 caarlos0 added the bug Something isn't working label Dec 21, 2023
@caarlos0 caarlos0 added this to the v1.23.0 milestone Dec 21, 2023
@caarlos0 caarlos0 self-assigned this Dec 21, 2023
caarlos0 added a commit that referenced this issue Dec 21, 2023
@caarlos0
fix(nix): include unzip if any artifact is a zip (#4495)
2b9e471 
Instead of just the first one.

refs #4224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging a pull request may close this issue.

feat(nix): support zip packages goreleaser/goreleaser
2 participants
@caarlos0 @lionello