fix: decouple project_name guessing from the release pipe #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## main #4335 +/- ##
==========================================
- Coverage 83.90% 83.89% -0.01%
==========================================
Files 133 133
Lines 12716 12711 -5
==========================================
- Hits 10669 10664 -5
Misses 1630 1630
Partials 417 417
|
Deploying with
|
| Latest commit: |
b1b661e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://58f0813f.goreleaser.pages.dev |
| Branch Preview URL: | https://project-name-guess.goreleaser.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the release's defaults run before the project's does, so, usually the github/gitlab/gitea names are set.
however, in some cases, the release's defaults might be skipped, in which case they'll be empty.
this breaks things like
goreleaser changelog, especially on non-go repositories.this pr tries to extract the project name from the git remote url in the project's defaulter.
it might be possible now to move it to run before the release defaulter, even.