feat(docs): Update command in SLSA verification blog post #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: laurentsimon <laurentsimon@google.com>
pull-request-size
bot
added
the
size/S
laurentsimon
changed the title
Signed-off-by: laurentsimon <laurentsimon@google.com>
caarlos0
approved these changes
Nov 13, 2023
|
LGTM. cc/ @developer-guy |
developer-guy
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
LGTM approved, thanks @laurentsimon for improving the blog 😋
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great blog post! I added it to the documentation of the https://github.com/slsa-framework/slsa-github-generator :)
This PR fixes the command to verify SLSA provenance in the blog post https://goreleaser.com/blog/slsa-generation-for-your-artifacts/.
The verification for binary artifacts is correct.
The verification for container images is incorrect:
This follows the same steps on argoCD's documentation https://argo-cd.readthedocs.io/en/stable/operator-manual/signed-release-assets/#verification-of-container-image-with-slsa-attestations
Thanks!