Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update CONTRIBUTING.md add upx as optional prerequesite #4427

Merged
merged 1 commit into from Nov 18, 2023
Merged

docs: update CONTRIBUTING.md add upx as optional prerequesite #4427

merged 1 commit into from Nov 18, 2023

Conversation

gabrielcipriano
Copy link
Contributor

A test failed as I didn't had upx installed:

--- FAIL: TestRun (0.58s)
    upx_test.go:119: 
                Error Trace:    /home/cipri/git/goreleaser/internal/pipe/upx/upx_test.go:119
                Error:          Received unexpected error:
                                upx not found in PATH
                Test:           TestRun
FAIL

...

...

...

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2023
@caarlos0 caarlos0 merged commit 11e5682 into goreleaser:main Nov 18, 2023
4 of 5 checks passed
@caarlos0
Copy link
Member

Thank you!

@github-actions github-actions bot added this to the v2.0.0 milestone Nov 18, 2023
@caarlos0 caarlos0 modified the milestones: v2.0.0, v1.23.0 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabrielcipriano @caarlos0