Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linkedin announce api changes #4428

Merged

Conversation

gabrielcipriano
Copy link
Contributor

@gabrielcipriano gabrielcipriano commented Nov 18, 2023

Closes #4421

I chose to keep getProfileID as getProfileIDLegacy and use it as a fallback if getProfileSub fails because of permission scope.

In this way, it's not a breaking change because one that has only a deprecated permissions such as r_liteprofile will still be able to hit v2/me

this logic is encapsulated in the new function getProfileURN, that resolves the user identifier and returns it formatted as a URN

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (57f2532) 83.90% compared to head (32916b0) 83.80%.

Files Patch % Lines
internal/pipe/linkedin/client.go 57.44% 14 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4428      +/-   ##
==========================================
- Coverage   83.90%   83.80%   -0.10%     
==========================================
  Files         133      133              
  Lines       12769    12810      +41     
==========================================
+ Hits        10714    10736      +22     
- Misses       1637     1650      +13     
- Partials      418      424       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 59a3eeb into goreleaser:main Nov 18, 2023
8 of 11 checks passed
@caarlos0
Copy link
Member

awesome, thank you!

@caarlos0 caarlos0 added the bug Something isn't working label Nov 18, 2023
@github-actions github-actions bot added this to the v2.0.0 milestone Nov 18, 2023
@caarlos0 caarlos0 modified the milestones: v2.0.0, v1.23.0 Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linkedin: could not get profile id: could not find 'id' in result
2 participants