Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate ko's main path #4429

Merged
merged 3 commits into from Nov 19, 2023
Merged

Conversation

gabrielcipriano
Copy link
Contributor

closes #4382

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57f2532) 83.90% compared to head (7a2bf75) 83.82%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4429      +/-   ##
==========================================
- Coverage   83.90%   83.82%   -0.08%     
==========================================
  Files         133      133              
  Lines       12769    12825      +56     
==========================================
+ Hits        10714    10751      +37     
- Misses       1637     1650      +13     
- Partials      418      424       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 8f6b16f into goreleaser:main Nov 19, 2023
9 of 12 checks passed
@caarlos0
Copy link
Member

amazing, thank you!

@github-actions github-actions bot added this to the v2.0.0 milestone Nov 19, 2023
@gabrielcipriano
Copy link
Contributor Author

amazing, thank you!

cheers!

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 19, 2023
@caarlos0 caarlos0 modified the milestones: v2.0.0, v1.23.0 Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kos don't seem to infer main from build correctly
2 participants