Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow homebrew to use tar.xz format #4441

Merged
merged 1 commit into from Nov 24, 2023

Conversation

jftuga
Copy link
Contributor

@jftuga jftuga commented Nov 24, 2023

In a brews section, goreleaser will fail when using format: tar.xz even though homebrew supports installing binaries bundled in a .tar.xz archive.

I use .tar.xz instead of .tar.gz and would like goreleaser to support this when used in conjunction with brews sections.

With this patch, I created a test homebrew formulae and successfully installed it under macOS.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (103b54b) 83.83% compared to head (d8f6f68) 83.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4441   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         133      133           
  Lines       12831    12831           
=======================================
  Hits        10757    10757           
  Misses       1650     1650           
  Partials      424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jftuga
Copy link
Contributor Author

jftuga commented Nov 24, 2023

@caarlos0 What do I need to do in order to resolve the golangci-lint errors? FWIW, this is a very small patch.

@caarlos0
Copy link
Member

@jftuga I need to fix the settings to ignore older errors actually, don't worry about it.

@caarlos0 caarlos0 merged commit 74e7064 into goreleaser:main Nov 24, 2023
10 of 11 checks passed
@caarlos0
Copy link
Member

thanks for the PR :)

@github-actions github-actions bot added this to the v2.0.0 milestone Nov 24, 2023
@jftuga jftuga deleted the homebrew-tarxz branch November 24, 2023 19:34
@caarlos0 caarlos0 modified the milestones: v2.0.0, v1.23.0 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants