Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying OS specific dependency in Homebrew #4480

Closed
3 of 4 tasks
avinassh opened this issue Dec 15, 2023 · 2 comments · Fixed by #4481
Closed
3 of 4 tasks

Specifying OS specific dependency in Homebrew #4480

avinassh opened this issue Dec 15, 2023 · 2 comments · Fixed by #4481
Assignees
Labels
enhancement New feature or request

Comments

@avinassh
Copy link

What happened?

I want to specify a OS specific dependency:

  depends_on "my-app" if OS.mac?

but following:

    dependencies:
      - name: my-app if OS.mac?

generates:

  depends_on "my-app if OS.mac?"

As an alternative, I couldn't find a way to generate the following either:

 if OS.mac?
    depends_on "my-app"
  end

How can we reproduce this?

The sample from here: https://goreleaser.com/customization/homebrew/ can be used to reproduce

goreleaser version

GitVersion:    1.22.1
GitCommit:     52d976beaea9ba8a5b0f09f90f22135b468c33c2
GitTreeState:  dirty
BuildDate:     2023-11-08T23:40:43
BuiltBy:       homebrew
GoVersion:     go1.21.4
Compiler:      gc
ModuleSum:     unknown
Platform:      darwin/amd64

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@avinassh avinassh added bug Something isn't working triage Issue pending triage by one of the maintainers labels Dec 15, 2023
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Dec 15, 2023
caarlos0 added a commit that referenced this issue Dec 15, 2023
@caarlos0
Copy link
Member

caarlos0 commented Dec 15, 2023

missing feature, not a bug.

adeed in #4481

@caarlos0 caarlos0 added enhancement New feature or request and removed bug Something isn't working labels Dec 15, 2023
@avinassh
Copy link
Author

That was fast. Thank you so much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants