Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nix): validate licenses #4497

Merged
merged 1 commit into from Dec 26, 2023
Merged

feat(nix): validate licenses #4497

merged 1 commit into from Dec 26, 2023

Conversation

caarlos0
Copy link
Member

this will check if the license provided by the user is a valid one.

valid list of licenses is generated from nix's source code.

closes #4496

this will check if the license provided by the user is a valid one.

valid list of licenses is generated from nix's source code.

closes #4496
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 21, 2023
@caarlos0 caarlos0 added this to the v1.23.0 milestone Dec 21, 2023
@caarlos0 caarlos0 self-assigned this Dec 21, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2023
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1cda4b
Status: ✅  Deploy successful!
Preview URL: https://e5f2ff80.goreleaser.pages.dev
Branch Preview URL: https://nix-licenses.goreleaser.pages.dev

View logs

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4dafdf) 83.82% compared to head (f1cda4b) 83.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4497   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files         135      135           
  Lines       12823    12826    +3     
=======================================
+ Hits        10749    10752    +3     
  Misses       1650     1650           
  Partials      424      424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit dda1c70 into main Dec 26, 2023
12 checks passed
@caarlos0 caarlos0 deleted the nix-licenses branch December 26, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nix setup does not validate licenses
1 participant