Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(winget): support installing .exe directly #4498

Merged
merged 5 commits into from Dec 26, 2023
Merged

feat(winget): support installing .exe directly #4498

merged 5 commits into from Dec 26, 2023
+179 −19

Conversation

caarlos0
Copy link
Member

closes #4494

@caarlos0 caarlos0 self-assigned this Dec 21, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 21, 2023
@caarlos0 caarlos0 added enhancement New feature or request and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 21, 2023
@caarlos0 caarlos0 added this to the v1.23.0 milestone Dec 21, 2023
@caarlos0 caarlos0 mentioned this pull request Dec 21, 2023
Closed
3 tasks
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Dec 21, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e12557b
Status: ✅  Deploy successful!
Preview URL: https://4c6b06ca.goreleaser.pages.dev
Branch Preview URL: https://winget-bin.goreleaser.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2b9e471) 83.82% compared to head (e12557b) 83.82%.

Files Patch % Lines
internal/pipe/winget/winget.go 92.10% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4498   +/-   ##
=======================================
  Coverage   83.82%   83.82%           
=======================================
  Files         135      135           
  Lines       12824    12843   +19     
=======================================
+ Hits        10750    10766   +16     
- Misses       1650     1652    +2     
- Partials      424      425    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vedantmgoyal9
vedantmgoyal9 suggested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caarlos0 Package identifier is Publisher.Project, so artifacts should start with min (project) and not foo (publisher).

@vedantmgoyal9
Copy link
Contributor

vedantmgoyal9 commented Dec 22, 2023 •
edited

well @caarlos0, we can change the package identifier to Min.Foo, which I think will be easier than replacing the artifact names. however, then the moniker also needs to be updated to foo and also PackageName and Publisher have to be inter-changed in Locale manfiest.

@caarlos0 @vedantmgoyal9
Update internal/pipe/winget/winget.go
9188dbb 
Co-authored-by: Vedant <83997633+vedantmgoyal2009@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 26, 2023
@caarlos0
Copy link
Member Author

@vedantmgoyal2009 updated

@caarlos0 caarlos0 merged commit 27f0e33 into main Dec 26, 2023
12 checks passed
@caarlos0 caarlos0 deleted the winget-bin branch December 26, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedantmgoyal9 vedantmgoyal9 vedantmgoyal9 requested changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Publishing to winget without archiving
2 participants
@caarlos0 @vedantmgoyal9