Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting wrap_in_directory: true in archives breaks aurs Arch pkgs #4500

Closed
3 of 4 tasks
blacktop opened this issue Dec 23, 2023 · 1 comment · Fixed by #4502
Closed
3 of 4 tasks

Setting wrap_in_directory: true in archives breaks aurs Arch pkgs #4500

blacktop opened this issue Dec 23, 2023 · 1 comment · Fixed by #4502
Assignees
Labels
bug Something isn't working

Comments

@blacktop
Copy link

blacktop commented Dec 23, 2023

What happened?

If you set wrap_in_directory: true you also need to add an extra cd into dir to the steps of the package: fields.

How can we reproduce this?

Set wrap_in_directory: true and create a arch pkgs

goreleaser version

❯ goreleaser --version
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    1.22.1
GitCommit:     52d976beaea9ba8a5b0f09f90f22135b468c33c2
GitTreeState:  false
BuildDate:     2023-11-08T23:40:43Z
BuiltBy:       goreleaser
GoVersion:     go1.21.4
Compiler:      gc
ModuleSum:     h1:7+P9DHpKPmg160mni77AC6x43tch0DKNqULIfrYRyOU=
Platform:      darwin/arm64

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

I guess this really isn't goreleaser's fault, but maybe needs a NOTE in the docs?

Do you know what template vars I should use to tell it what the folder would be to know what folder to cd into?

Maybe I could just change the install steps to be something like:

    package: |-
      # bin
      install -Dm755 "*/ipsw" "${pkgdir}/usr/bin/ipsw"

?

@blacktop blacktop added bug Something isn't working triage Issue pending triage by one of the maintainers labels Dec 23, 2023
@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Dec 26, 2023
caarlos0 added a commit that referenced this issue Dec 26, 2023
closes #4500

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member

hi!

thanks for reporting this, #4502 should do the trick

caarlos0 added a commit that referenced this issue Dec 26, 2023
closes #4500

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants