Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(brew): improve handling of single os #4562

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(brew): improve handling of single os #4562

merged 1 commit into from
Jan 19, 2024

Conversation

caarlos0
Copy link
Member

  • refactors brew template into separated files using embed.FS
  • moves the macos and linux packages to different template files
  • includes and indent those accordingly to which OSes are supported

closes #4561

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Jan 19, 2024
@caarlos0 caarlos0 added this to the v1.24.0 milestone Jan 19, 2024
@caarlos0 caarlos0 self-assigned this Jan 19, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@116a034). Click here to learn what that means.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/pipe/brew/brew.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4562   +/-   ##
=======================================
  Coverage        ?   83.75%           
=======================================
  Files           ?      135           
  Lines           ?    12938           
  Branches        ?        0           
=======================================
  Hits            ?    10836           
  Misses          ?     1673           
  Partials        ?      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit ac398de into main Jan 19, 2024
12 checks passed
@caarlos0 caarlos0 deleted the brew branch January 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove on_macos do from Homebrew Formula when only macOS binary is built
1 participant