Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] continuous benchmarking with gobencher #640

Closed
odeke-em opened this issue Sep 5, 2021 · 1 comment
Closed

[feature] continuous benchmarking with gobencher #640

odeke-em opened this issue Sep 5, 2021 · 1 comment

Comments

@odeke-em
Copy link

odeke-em commented Sep 5, 2021

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is - e.g. "I'm always frustrated when [...]"

The ability to trivially benchmark and examine regressions as they happen. Regressions currently can happen and they aren't caught. Luckily we've got folks like @harshavardhana and @klauspost who read through the code manually or noticed hot paths on their server, and will go fix problems like in #579 and #544, but unfortunately that change #579 didn't include benchmark results, though here are what they look like
https://dashboard.github.orijtech.com/benchmark/f746b02388744f02b238f582d1a87dfb
Screen Shot 2021-09-05 at 12 57 49 PM

Describe the solution you'd like

What would the feature look like? How would it work? How would it change the API?

On the Github marketplace, you can add gobencher in 1-click per https://github.com/marketplace/gobencher and then you'll never have to worry about benchmarking, all commits will be benchmarked against the base branch automatically and reuslts presented to you, hassle free!

Describe alternatives you've considered

Are there alternatives you've tried, and/or workarounds in-place?

Manually benchmarking every change -- this is tedious, error prone and no one does this consistently in practice. We've detailed why and how we built bencher per https://medium.com/orijtech-developers/bencher-b60cc82e3ef1

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

@stale stale bot added the stale label Jan 9, 2022
@stale stale bot closed this as completed Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant