Fix encoding request when params are nil #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a test that can updated/added to verify this and ensure that we don't have any regressions in the future? (also need to fix the conflict) |
|
Going to close this PR request because it's wrong. The difference between jsonrpc 1 and jsonrpc 2 is that params may be omitted The package rpc/v2/json2 contains a client which omits that field (readme also points I was just using the wrong client (1.0) instead of the correct one(2.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
Summary of Changes
When calling method with args nil, the interface marshals into
null, which gives usparams: [null]and RPC server that does not require parameter will yield error.This fix sets the params only if args are not nil, otherwise it will be an empty interface which will give us
params: []