Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct substitution for bulgarian 'Щ' #80

Merged
merged 1 commit into from Feb 23, 2024
Merged

Conversation

kvalev
Copy link
Contributor

@kvalev kvalev commented May 18, 2023

Probably due to a copy-paste error the substitution for Ш and Щ was identical, but only for the uppercase variants.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (76470d7) to head (d923cc0).

❗ Current head d923cc0 differs from pull request most recent head b33dd82. Consider uploading reports for the commit b33dd82 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          119       142   +23     
=========================================
+ Hits           119       142   +23     
Files Coverage Δ
languages_substitution.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@kvalev
Copy link
Contributor Author

kvalev commented May 30, 2023

@matrixik Can you take a look when you get the chance?

@matrixik matrixik added the bug label Feb 23, 2024
@matrixik matrixik merged commit 78044c1 into gosimple:master Feb 23, 2024
4 checks passed
@matrixik
Copy link
Member

Thank you for your fix and sorry it took so long.

@kvalev kvalev deleted the patch-1 branch February 28, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants