You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version 1.32 introduces a breaking change on PR #329, since it changes the Logger interface. Since the module is marked as stable this introduces some issues on (direct and indirect) consumers of this module because of Go minimal version selection. For example, one can't use v1.32 of the module if you have a dependency that uses v1.31 's Logger, since Go picks one and only one version to use. This is a common problem on other libraries that make breaking changes like grpc-go (see e.g. etcd-io/etcd#12124 which makes it impossible for anyone depending, directly or indirectly, on etcd v3.4 to use any grpc version higher than v1.29.0).
One possible way to prevent this in the future is to use apidiff or a similar tool on the CI. I don't have enough context to judge if the Logger change should be reverted or not, but it's a possibility to retract a version on your go.mod file if necessary.
The text was updated successfully, but these errors were encountered:
Version 1.32 introduces a breaking change on PR #329, since it changes the
Logger
interface. Since the module is marked as stable this introduces some issues on (direct and indirect) consumers of this module because of Go minimal version selection. For example, one can't use v1.32 of the module if you have a dependency that uses v1.31 'sLogger
, since Go picks one and only one version to use. This is a common problem on other libraries that make breaking changes like grpc-go (see e.g. etcd-io/etcd#12124 which makes it impossible for anyone depending, directly or indirectly, on etcd v3.4 to use any grpc version higher than v1.29.0).One possible way to prevent this in the future is to use
apidiff
or a similar tool on the CI. I don't have enough context to judge if the Logger change should be reverted or not, but it's a possibility toretract
a version on your go.mod file if necessary.The text was updated successfully, but these errors were encountered: