Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment源代码分析有误 #21

Open
yipeng1030 opened this issue May 7, 2024 · 0 comments
Open

deployment源代码分析有误 #21

yipeng1030 opened this issue May 7, 2024 · 0 comments

Comments

@yipeng1030
Copy link

yipeng1030 commented May 7, 2024 •
edited

感谢作者的源码分析，在学习过程中发现一处值得讨论的地方
image
你提到deployment在rollout 暂停状态下会执行完未完成的scale后不再响应scale，但这篇blog
image
image
中Scaling Paused Deployments一节的实验，在rollout paused状态下仍然可以scale in。
结合源代码分析，scale的常规入口确实在pause后不再执行，但pause直接进入了和scale相同的sync处理函数中，是否相当于pause后直接在sync函数中进行scale操作的调谐呢？
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yipeng1030