Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTag: Use computed property for router link #194

Open
igeligel opened this issue Sep 3, 2019 · 4 comments
Open

VTag: Use computed property for router link #194

igeligel opened this issue Sep 3, 2019 · 4 comments

Comments

@igeligel
Copy link
Collaborator

igeligel commented Sep 3, 2019

<router-link
  :to="{ name: 'home-tag', params: { tag: name } }"
  :class="className"
>

Ideally, { name: 'home-tag', params: { tag: name } } should be a computed property and then used like:

<router-link
  :to="homeLink"
  :class="className"
>

Related resources:

@kylerits
Copy link

kylerits commented Oct 2, 2019

I can tackle this if you don't mind.

@kylerits
Copy link

kylerits commented Oct 4, 2019

PR at #224

@andriyfm
Copy link
Contributor

andriyfm commented Oct 6, 2019

Use computed property for router link #231

@khuongphp
Copy link

@andriyfm this PR got error that name is null
We should accept pull request of @kylerits . That PR fix my error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants