Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform Update User call to async/await #68

Open
igeligel opened this issue Oct 12, 2018 · 2 comments
Open

Transform Update User call to async/await #68

igeligel opened this issue Oct 12, 2018 · 2 comments

Comments

@igeligel
Copy link
Collaborator

Issue Summary:

In the auth.module.js here you have got some code like:

[UPDATE_USER](context, payload) {
  const { email, username, password, image, bio } = payload;
  const user = {
    email,
    username,
    bio,
    image
  };
  if (password) {
    user.password = password;
  }

  return ApiService.put("user", user).then(({ data }) => {
    context.commit(SET_AUTH, data.user);
    return data;
  });
}

Those promise calls could be simplified with async and await calls.

Resources:

Acceptance Criteria:

  • A test is introduced, this is perfect work for TDD
  • There is no .then(... or .catch(... block or any promise like structure

The main issue can be found here #5

@jkmdev
Copy link
Contributor

jkmdev commented Oct 12, 2018

I'll have a go at this one as well

@jkmdev
Copy link
Contributor

jkmdev commented Oct 13, 2018

@igeligel Stopped working on this for the time being because of #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants