-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make boards more consistent #137
Comments
How should the last move marker for Taengeuk Stones look? |
Yeah that's a tough one. The linked solution looks mostly good, but does it work for gray stones? Another solution might be something like:
|
For some gray stones it wouldn't work. A filter that does something like Another option would be to define an indicator color for each stone color. And maybe have users pick an indicator color if they are allowed to define the stone color freely. |
Maybe that's what we want: But it's an "experimental technology" and not supported by any major browser yet. Apparently |
Currently, there are 3-4 ways to make a standard looking Baduk board:
Some features are different by design:
But some features are mismatched for no good reason (I'm not sure this is a complete list, but this is everything I noticed):
The task is to make the boards more consistent as the differences are quite obvious when they occur together on the game page. There may also be room for deduping the classes.
BadukBoard
may be implemented as a specialization ofBadukBoardAbstract
orMulticolorGridBoard
, andFractionalBoard
may be able to implement all four (although I am hesitant to replace grid-based boards with graph-based boards for performance reasons).The text was updated successfully, but these errors were encountered: