Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display komi and other "invisible" configs #238

Open
benjaminpjones opened this issue Apr 15, 2024 · 1 comment
Open

Display komi and other "invisible" configs #238

benjaminpjones opened this issue Apr 15, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@benjaminpjones
Copy link
Collaborator

Some configs like width and height are visible on the board. However, Komi can't be deduced until the game is over. Maybe we can show this below the description or in an info panel.

@benjaminpjones benjaminpjones added the good first issue Good for newcomers label Apr 28, 2024
@benjaminpjones
Copy link
Collaborator Author

benjaminpjones commented Apr 28, 2024

Good First Issue

Please see the README for instructions on getting your developer environment set up.

Code pointers

This information should go somewhere in the GameView. Maybe right under the variant description:

<div id="variant-info">
<div>
<span class="info-label">Variant:</span>
<span class="info-attribute">
{{ gameResponse.variant ?? "unknown" }}
</span>
</div>
<div>
<span class="info-label">Description:</span>
<span class="info-attribute">{{ variantDescriptionShort }}</span>
</div>
</div>

The config is a member of gameResponse defined here:

const gameResponse: GameResponse = reactive(DEFAULT_GAME);

Technologies used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant