Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: gridcell ARIA role incorrectly added to Day button element #1688

Open
gpbl opened this issue Feb 11, 2023 Discussed in #1674 · 3 comments · May be fixed by #1708 or #2089
Open

Bug: gridcell ARIA role incorrectly added to Day button element #1688

gpbl opened this issue Feb 11, 2023 Discussed in #1674 · 3 comments · May be fixed by #1708 or #2089
Assignees
@gpbl
Labels
Accepted Changes have been accepted and will go in one of the next releases. accessibility In Progress Work in Progress
Milestone
v9.0.0

Comments

@gpbl
Copy link
Owner

gpbl commented Feb 11, 2023

Discussed in #1674

Originally posted by rihardsgravis February 2, 2023

Bug description

The ARIA gridcell role is added to the Day button, but that is an incorrect role for the button since it does not represent a cell in a grid – it is in fact a child of a cell. Accessibility tests using the component are failing.

Expected behaviour

The role for the button could be button or omitted at all since it's a HTM button component and the role for it is clear.
@dougmacknz dougmacknz mentioned this issue Feb 20, 2023
Closed
@Kosai106 Kosai106 linked a pull request Mar 2, 2023 that will close this issue
Draft
@gpbl gpbl added the In Progress Work in Progress label Apr 9, 2023
@reintroducing
Copy link

reintroducing commented Apr 10, 2023 •
edited

@gpbl for what its worth, aria-selected is also erroring as Critical with aXe. I'm having to destructure it out of the buttonProps and leave it as an unused variable to avoid the errors.

Screenshot 2023-04-10 at 11 31 11 AM

@gpbl gpbl added this to the v9 milestone Apr 14, 2023
@gpbl gpbl added the Accepted Changes have been accepted and will go in one of the next releases. label Aug 16, 2023
@HeartSquared HeartSquared mentioned this issue Jan 17, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 18, 2024
Merged
@jacobsickels
Copy link

Waiting on a fix for this!

@gpbl gpbl self-assigned this Apr 16, 2024
@connor-baer connor-baer mentioned this issue Apr 16, 2024
Open
@gpbl gpbl linked a pull request Apr 17, 2024 that will close this issue
Draft
4 tasks
@gpbl
Copy link
Owner Author

gpbl commented Apr 17, 2024

Reason this is taking so long is because it is a breaking change: changing the HTML structure will likely break tests selectors and styles.

I could finally make some progress with this in PR #2089 and will cut a mayor release for this fix. More details coming soon... thanks a lot for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpbl gpbl

Labels
Accepted Changes have been accepted and will go in one of the next releases. accessibility In Progress Work in Progress
Projects
None yet
Milestone
v9.0.0
3 participants
@gpbl @reintroducing @jacobsickels