Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgpu:api,operation,labels:wrappers_do_not_share_labels:* calls createRenderPipeline with no target #3754

Closed
jimblandy opened this issue May 19, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@jimblandy
Copy link

The algorithm validatingGPURenderPipelineDescriptor says:

But webgpu:api,operation,labels:wrappers_do_not_share_labels:* tries to create a render pipeline without any attachments:

    const pipeline = t.device.createRenderPipeline({
      layout: 'auto',
      vertex: {
        module,
        entryPoint: 'main',
      },
    });
@kainino0x
Copy link
Collaborator

kainino0x commented May 21, 2024

Thank you for catching this!
I am surprised that Dawn passes this test. I thought we had tests for this validation. I'm pretty sure we do for render passes, I guess we missed it for render pipelines. I have filed https://crbug.com/341812551

We'll also of course need to test that, since I guess we're not testing it. (EDIT: ... which Erich already filed. #3755)

@Kangz

This comment was marked as resolved.

@ErichDonGubler

This comment was marked as resolved.

@Kangz

This comment was marked as resolved.

@ErichDonGubler
Copy link
Member

Resolved with #3756. I've filed an issue for validating this specific case at #3755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Open (no TODO)
Development

No branches or pull requests

4 participants