Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect vertex formats dropped for macOS < 10.13 #4549

Open
kainino0x opened this issue Mar 27, 2024 · 2 comments
Open

Resurrect vertex formats dropped for macOS < 10.13 #4549

kainino0x opened this issue Mar 27, 2024 · 2 comments
Labels
api resolved Resolved - waiting for a change to the API specification api WebGPU API
Milestone

Comments

@kainino0x
Copy link
Contributor

kainino0x commented Mar 27, 2024

In #231 we dropped a bunch of vertex formats that required macOS 10.13+.

In #1069 (comment), a year ago, we decided to require 10.13.

I knew we were missing some random stuff that we should have added back when we decided that, but that's a pretty major one. (It was not even 2 years a lot of years in between the two.)

We should add these back. List but with names updated:

MTLVertexFormatUChar --> uint8
MTLVertexFormatChar --> sint8
MTLVertexFormatUCharNormalized --> unorm8
MTLVertexFormatCharNormalized --> snorm8

MTLVertexFormatUShort --> uint16
MTLVertexFormatShort --> sint16
MTLVertexFormatUShortNormalized --> unorm16
MTLVertexFormatShortNormalized --> snorm16
MTLVertexFormatHalf --> float16

MTLVertexFormatUChar4Normalized_bgra --> unorm8x4-bgra / unorm8bgra (spelling?)

All of these are required in Vulkan 1.0 and D3D FL11_0.

(The 3-component formats we removed for D3D12 still can't be added back.)

@kainino0x
Copy link
Contributor Author

In #508 (comment) we decided to require 10.13.

Sorry, wrong link. Correct one is #1069 (comment)
(It was more years later.)

@Kangz
Copy link
Contributor

Kangz commented Apr 9, 2024

GPU Web WG 2024-03-27
  • CW: seems easy except for one tiny name bikeshedding.
  • KN: dropped these a year ago - no reason any more to continue excluding them.
  • CW: one q, how do we name the unorm8bgra?
  • KN: regular one's unorm8x4.
  • KG: if other one's x4, should call this one x4.
  • CW: unorm8x4-bgra seems clear.
  • Agreed all around.

@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label Apr 9, 2024
@kainino0x kainino0x added api resolved Resolved - waiting for a change to the API specification api WebGPU API and removed copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api resolved Resolved - waiting for a change to the API specification api WebGPU API
Projects
None yet
Development

No branches or pull requests

2 participants