-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compat: WGSL validation at createShaderModule or createPipeline time? #4568
Comments
Examples of the WGSL features to be validated out
|
Another interesting related issue is, compat does not support cube arrays but Instead, creating a texture view If it's decided to validate out the other WGSL features at shader module creation time this should probably be validated out too. If the others stay as a pipeline creation error I suspect this one will need to add a pipeline creation error too since there's nothing valid to translate the WGSL into GLSL. |
Can this be on the WGSL agenda? Compat is stalled until this is resolved. |
This was discussed at the last meeting: https://docs.google.com/document/d/1vaICnZrSK_3xexJhJsMGkj_vtie2WHnav1gADmEP-88/edit#bookmark=id.gbgc1udsz1hm The relevant part being:
|
WGSL 2024-04-30 Minutes
|
Currently, the compat proposal validates most WGSL restrictions at pipeline creation time. A validation error is only generated if the entry points used by the pipeline use one of the unsupported features.
Example:
This has the benefit that you can easily put shared code in the same module string and choose at runtime which entryPoint to use.
On the other hand, WGSL has chosen that unsupported or un-enabled features generate errors at shader module creation time. This has the advantage that errors have line/column numbers which is more informative.
Should the compat recommendation switch to errors at shader creation time? Stay at pipeline creation time? Do something else?
The text was updated successfully, but these errors were encountered: