Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec web page word highlight feature has low contrast in dark mode #4598

Open
greggman opened this issue Apr 24, 2024 · 4 comments
Open

Spec web page word highlight feature has low contrast in dark mode #4598

greggman opened this issue Apr 24, 2024 · 4 comments
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) wgsl WebGPU Shading Language Issues
Milestone

Comments

@greggman
Copy link
Contributor

Some feature of the spec web page seems to highlight words clicked on, but those words have low-contrast in dark mode

Screenshot 2024-04-24 at 16 03 04

related: #3649

@greggman
Copy link
Contributor Author

greggman commented Apr 24, 2024

adding

@media (prefers-color-scheme: dark) {
  var[data-var-color] {
     color: black;
     filter: invert(1);
  }
}

Might solve it.

Screenshot 2024-04-24 at 16 21 40

@kainino0x
Copy link
Contributor

Don't think we're using any custom styling here, so this is a Bikeshed issue. Found speced/bikeshed#2157

@litherum
Copy link
Contributor

Should this issue be closed and marked as "moved?"

@kainino0x kainino0x added wgsl WebGPU Shading Language Issues copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) api WebGPU API labels Apr 30, 2024
@kainino0x
Copy link
Contributor

I think I'd like to keep it open here since it's still an active problem with our spec. Maybe one of us will go contribute a fix to Bikeshed (or make a quick patch in our spec, though fixing bikeshed shouldn't be hard)

@kainino0x kainino0x added this to the Milestone 1 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api WebGPU API copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) wgsl WebGPU Shading Language Issues
Projects
None yet
Development

No branches or pull requests

3 participants