Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a diagnostic triggered when a pipeline-constant is set for an override in the shader module that is not used by the entry point #4643

Open
dneto0 opened this issue May 15, 2024 · 0 comments
Labels
wgsl WebGPU Shading Language Issues
Milestone

Comments

@dneto0
Copy link
Contributor

dneto0 commented May 15, 2024

This is forked from #4624

During pipeline creation time, it is valid for a pipeline constant to be set for an override that exists in the shader but is not statically accessed by the entry point.
In the discussion from #4624 we agreed it would be nice to add a diagnostic, defaulting to off that would trigger in this case.
It's an extra guardrail that the developer can opt into.

To be determined:

  • It certainly makes sense as a module-wide diagnostic directive.
  • For a range diagnostic filter, where should it take affect or be allowed?
    • On the entry point?
    • On the declaration of the override? Currently range diagnostic filters are not specified to be allowed on a variable declaration.
  • The name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wgsl WebGPU Shading Language Issues
Projects
None yet
Development

No branches or pull requests

1 participant