-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide def release_version(self) for BinarySuite #71
Comments
Have you seen a failure? If so, under what conditions? This should not fail as this code is only called when building the JVMCI JDK and when JVMCI is a binary suite this step is not necessary. |
Yes. We have a project that transitively depends on jvmci that builds (and uses) jvm-product-server-linux-amd64. If I binary deploy all transitive dependencies and then use them via But when I define a dummy implementation for release_version(self) in BinarySuite everything works a expected. |
When you execute |
I will send you a console log via email. |
Sorry, I got confused and interpreted What does your dummy implementation look like? Worth creating a PR from it? |
I don't think so:
|
That seems reasonable to me - I don't know where else could we get version info from a binary suite? |
* commit 'dede2c157563190771029fd3afa35f04b7c2633d': Projects should reference all other projects they need and relevant resources shouldn't contain distributions
The call to
_updateGraalPropertiesFile()
inmx.graal-core/mx_graal_8.py line 73
will fail with jvmci imported as binary suite because there is no definition ofdef release_version(self)
forBinarySuite
. A proper definition needs to be added.The text was updated successfully, but these errors were encountered: