Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to use a custom distribution URL #60

Open
sgammon opened this issue Sep 13, 2023 · 1 comment · May be fixed by #61
Open

Ability to use a custom distribution URL #60

sgammon opened this issue Sep 13, 2023 · 1 comment · May be fixed by #61
Assignees
@sgammon @fniephaus
Labels
enhancement New feature or request

Comments

@sgammon
Copy link

sgammon commented Sep 13, 2023

Hey there GraalVM team,

I'm testing against GVM master for a few bugs which are anticipated to be fixed in the upcoming Sept release. While I could figure out how to use a dev release, I couldn't find a way to use a custom distribution URL (in case testing needs to be done against a completely custom GVM distribution).

I wanted to humbly request a way to do this, and I intend to offer a PR as well shortly.
sgammon added a commit to elide-dev/setup-graalvm that referenced this issue Sep 13, 2023
@sgammon
Add distribution_url property to override download URL
4f805f7 
Adds a `distribution_url` property to the action, which overrides
the download URL unconditionally. It is up to the caller to
provide an archive which works on their Github Actions runner;
there is no way (at this time) to vary the distribution URL by
architecture or OS.

- feat: add `distribution_url` input option
- feat: honor `distribution_url` in all branches
- chore: update docs with `distribution_url` info

Fixes and closes graalvm#60
@sgammon sgammon linked a pull request Sep 13, 2023 that will close this issue
Open
sgammon added a commit to elide-dev/setup-graalvm that referenced this issue Sep 13, 2023
@sgammon
Add distribution_url property to override download URL.
0711c08 
Adds a `distribution_url` property to the action, which overrides
the download URL unconditionally. It is up to the caller to
provide an archive which works on their Github Actions runner;
there is no way (at this time) to vary the distribution URL by
architecture or OS.

- feat: add `distribution_url` input option
- feat: honor `distribution_url` in all branches
- chore: update docs with `distribution_url` info

Fixes and closes graalvm#60

Signed-off-by: Sam Gammon <sam@elide.ventures>
@fniephaus
Copy link
Member

While I could figure out how to use a dev release.

java-version: 'dev' is what you need to use a GraalVM dev build. If this is not clear enough in the README.md, maybe you have an idea how we can improve the docs?

I intend to offer a PR as well shortly.

Thank you! Generally, I'm not against distribution_url but if your only use case is to use a dev build, then I'm not sure this is the right thing to do. The main reason for this is that GraalVM dev builds are volatile: we only keep the last N builds around. This means that whatever URL you decide to use, it will become unavailable and break your builds within a few weeks. java-version: 'dev', on the other hand, always pulls the latest dev build.

@fniephaus fniephaus added the enhancement New feature or request label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgammon sgammon

@fniephaus fniephaus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add distribution_url property to override download URL elide-dev/setup-graalvm
2 participants
@sgammon @fniephaus