Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podfile.lock version ignored on initial install #2

Open
icecrystal23 opened this issue Oct 25, 2019 · 2 comments
Open

Podfile.lock version ignored on initial install #2

icecrystal23 opened this issue Oct 25, 2019 · 2 comments

Comments

@icecrystal23
Copy link

I was testing out this plugin and noticed that it upgraded a library when I first tried it out. It ignored the version in our Podfile.lock and instead installed the highest compatible version matching the version in the Podfile (we have '~> 5.2.0' in the Podfile, 5.2.5 in Podfile.lock and this plugin used 5.2.7

@biocross
Copy link

For now, I'd recommend specifying the exact version in your MergeFile, since the plugin does not have context from the Podfile.lock and it only relies on the Mergefile. However, this is an interesting suggestion: I will look into this and see if the plugin can start reading the Podfile.lock as well. Thank you!

@biocross
Copy link

@icecrystal23 I was able to fix this issue by copying the top level Podfile.lock into each group's temporary pod install. That helps constraint the version of the each pod in the group during the internal pod install.

I'll release the fix soon with a new flag to allow disabling this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants