Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace M1 tag in capture-processor-arch samples with more generic term #582

Open
erichaagdev opened this issue Feb 9, 2023 · 3 comments

Comments

@erichaagdev
Copy link
Member

With M2 being made available, we should consider replacing the M1 tag in the capture-processor-arch samples with a more generic term (e.g. Apple Silicon).

See also: https://github.com/slackhq/kotlin-cli-util/blob/main/src/main/kotlin/slack/cli/AppleSiliconCompat.kt

@runningcode
Copy link
Member

Just a thought: this is why we don't add these things to CCUD. :)
Otherwise if we change this, it would break existing workflows. For example if a team were searching their dashboards for M1 they would suddenly not be able to find this if we changed the name. If we keep these in the samples, then teams can choose how to upgrade or change this.

@erichaagdev
Copy link
Member Author

That is a good point. I am okay with closing this issue.

@runningcode
Copy link
Member

I think we should update the sample for the very reason that it is a sample that can be manipulated by other developers when copy pasted. 👍 Also people don't tend to update "sample code".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants