Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper not restored correctly in Gradle User Home #293

Closed
bigdaz opened this issue May 28, 2022 · 1 comment
Closed

Wrapper not restored correctly in Gradle User Home #293

bigdaz opened this issue May 28, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bigdaz
Copy link
Member

bigdaz commented May 28, 2022

In order to accommodate upcoming changes in Gradle 7.5, v2.1.6 of this action started to save/restore the expanded distribution directory for a wrapper instead of the downloaded distribution zip (0e24fa1).

Unfortunately our test coverage failed to detect that this mechanism isn't working correctly with Gradle < 7.5: when Gradle discovers that the *.ok file is missing for the distribution it dutifully deletes the directory and re-downloads the distribution.

@bigdaz bigdaz added the bug Something isn't working label May 28, 2022
@bigdaz bigdaz self-assigned this May 28, 2022
@bigdaz bigdaz added this to the v2.1.7 milestone May 28, 2022
bigdaz added a commit that referenced this issue May 29, 2022
Due to #293 the current mechanism for caching wrappers is not working.
This is a temporary fix to ensure that save/restore of the entire directory works.
@bigdaz
Copy link
Member Author

bigdaz commented May 29, 2022

Fixed in v2.1.7

@bigdaz bigdaz closed this as completed May 29, 2022
bigdaz added a commit that referenced this issue May 29, 2022
Various improvements to CI workflows

- Compose all integ-test workflow executions into a single calling workflow
- Added a 'quick-check' workflow that provides faster feedback on branches other than main
  - Only runs on ubuntu-latest
  - Reuses cache entries from previous runs
  - Builds distribution outputs so that these don't need to be committed during everyday development
- Added a workflow for purging old workflow executions

Together with the fix for #293, these changes fix #291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant