Replace use of set-output command with env file #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbroyer
reviewed
Oct 20, 2022
| @@ -19,7 +19,7 @@ tasks.test { | |||
|
|
|||
| tasks.named("test").configure { | |||
| // Echo an output value so we can detect configuration-cache usage | |||
| println("::set-output name=task_configured::yes") | |||
| File(System.getenv("GITHUB_OUTPUT")).writeText("task_configured=yes\n") | |||
There was a problem hiding this comment.
This should probably be appendText to avoid overwriting previous output.
Suggested change
| File(System.getenv("GITHUB_OUTPUT")).writeText("task_configured=yes\n") | |
| File(System.getenv("GITHUB_OUTPUT")).appendText("task_configured=yes\n") |
There was a problem hiding this comment.
Thanks, but I'm having to replace this mechanism with a marker file.
Since the value of GITHUB_OUTPUT changes on each run, reading the environment variable itself causes the configuration-cache entry to be invalidated. This kind of defeats the purpose of this code, which is to verify that configuration caching was used!
- Use GITHUB_OUTPUT file in init script - Write to a marker file in configuratiion-cache tests Fixes #461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461