Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache key Validation Error when workflow name contains a comma #756

Closed
jebl01 opened this issue Jun 29, 2023 · 3 comments · Fixed by #757
Closed

Cache key Validation Error when workflow name contains a comma #756

jebl01 opened this issue Jun 29, 2023 · 3 comments · Fixed by #757
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jebl01
Copy link

jebl01 commented Jun 29, 2023

Our workflows contains commas in their names, this now makes the build fail with the following error:

Error: ValidationError: Key Validation Error: v8-gradle|Linux|Build, Test & Create Release-build[37a6259cc0c1dae299a7866489dff0bd]-d2138fa1b61e6a9ab14f6b45751a8118e6a378bb cannot contain commas.
ValidationError: Key Validation Error: v8-gradle|Linux|Build, Test & Create Release-build[37a6259cc0c1dae299a7866489dff0bd]-d2138fa1b61e6a9ab14f6b45751a81[18](https://github.com/webbhalsa/kry-medical-record/actions/runs/5409195640/jobs/9829089990#step:7:20)e6a378bb cannot contain commas.
    at checkKey (/home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:75:15)
    at Object.<anonymous> (/home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:108:13)
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:38:71
    at new Promise (<anonymous>)
    at __webpack_modules__.7799.__awaiter (/home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:34:12)
    at Object.restoreCache (/home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:98:12)
    at /home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:64485:47
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/gradle/gradle-build-action/v2/dist/main/index.js:64381:71

Most likely this is the commit that causes this:
2bf6bc3

@kimakunc
Copy link

kimakunc commented Jun 29, 2023

same problem, using the commit hash like so works for me:
i.e. :
gradle/gradle-build-action @ 631021b

vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jun 29, 2023
@bigdaz
Copy link
Member

bigdaz commented Jun 29, 2023

Thanks for the report. I'll get a fix out ASAP.
In the meantime you can continue to use v2.4.2

@bigdaz bigdaz changed the title v2 now throws exception if workflow name contains a comma Cache key Validation Error when workflow name contains a comma Jun 29, 2023
@bigdaz bigdaz added the bug Something isn't working label Jun 29, 2023
@bigdaz bigdaz added this to the v2.5.1 milestone Jun 29, 2023
@bigdaz bigdaz self-assigned this Jun 29, 2023
@bigdaz
Copy link
Member

bigdaz commented Jun 29, 2023

v2.5.1 was just released which should fix this issue. Apologies for the interruption!

vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
vcarluer added a commit to Cosmo-Tech/cosmotech-api that referenced this issue Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants