You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a kotlin subproject with Explicit API enabled. When I use apply-abi-change-to. The compilation fails because the function that is generated doesn't have the public modifier. Would it be possible to add it always?
The text was updated successfully, but these errors were encountered:
What happens if explicit-api=strict is set and function has a public modifier in Kotlin? Do you get compile warning of somekind that could break a build if you have allWarningsAsErrors=true?
I think the proposal is good and we could do that, we should just be careful that we don't break builds that doesn't have explicit-api=strict.
When you have explicit-api=strict and the function doesn't have the public modifier you get a compilation error. if you have the public modifier but you don't have explicit-api=strict the compiler doesn't complain. The IDE would mark it as "redundant" but the functions that gradle-profiler creates are not meant to be shown on any IDE so it should not be a problem.
I have a kotlin subproject with Explicit API enabled. When I use
apply-abi-change-to
. The compilation fails because the function that is generated doesn't have thepublic
modifier. Would it be possible to add it always?The text was updated successfully, but these errors were encountered: