Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin ABI change fails when explicit-api=strict #504

Open
BraisGabin opened this issue Jul 10, 2023 · 2 comments
Open

Kotlin ABI change fails when explicit-api=strict #504

BraisGabin opened this issue Jul 10, 2023 · 2 comments

Comments

@BraisGabin
Copy link

I have a kotlin subproject with Explicit API enabled. When I use apply-abi-change-to. The compilation fails because the function that is generated doesn't have the public modifier. Would it be possible to add it always?

@asodja
Copy link
Member

asodja commented Jul 12, 2023

What happens if explicit-api=strict is set and function has a public modifier in Kotlin? Do you get compile warning of somekind that could break a build if you have allWarningsAsErrors=true?

I think the proposal is good and we could do that, we should just be careful that we don't break builds that doesn't have explicit-api=strict.

@BraisGabin
Copy link
Author

When you have explicit-api=strict and the function doesn't have the public modifier you get a compilation error. if you have the public modifier but you don't have explicit-api=strict the compiler doesn't complain. The IDE would mark it as "redundant" but the functions that gradle-profiler creates are not meant to be shown on any IDE so it should not be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants