-
Notifications
You must be signed in to change notification settings - Fork 4.6k
/
DestroyerTaskCommandLineOrderIntegrationTest.groovy
466 lines (366 loc) · 21.1 KB
/
DestroyerTaskCommandLineOrderIntegrationTest.groovy
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
/*
* Copyright 2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.gradle.api
import org.gradle.integtests.fixtures.executer.TaskOrderSpecs
import spock.lang.Issue
class DestroyerTaskCommandLineOrderIntegrationTest extends AbstractCommandLineOrderTaskIntegrationTest {
def "destroyer task with a dependency in another project will run before producer tasks when ordered first (type: #type)"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').produces('build/foo', type)
def generateBar = bar.task('generateBar').produces('build/bar', type)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
where:
type << ProductionType.values()
}
def "a producer task will not run before a task in another project that destroys what it produces (type: #type)"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = foo.task('cleanBar').destroys('../bar/build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').produces('build/foo', type)
def generateBar = bar.task('generateBar').produces('build/bar', type)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
where:
type << ProductionType.values()
}
def "destroyer task with a dependency in another build will run before producer tasks when ordered first (type: #type)"() {
def foo = includedBuild('child').subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').produces('build/foo', type)
def generateBar = bar.task('generateBar').produces('build/bar', type)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
where:
type << ProductionType.values()
}
def "allows explicit task dependencies to override command line order"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
// conflicts with command line order
cleanBar.dependsOn(generateBar)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(generateBar.fullPath, cleanBar.fullPath)
}
}
def "allows command line order to override shouldRunAfter relationship"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
// conflicts with command line order
cleanBar.shouldRunAfter(generateBar)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath)
}
}
def "destroyer task with a dependency in another project followed by a producer task followed by a destroyer task are run in the correct order"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def cleanFooLocal = foo.task('cleanFooLocalState').destroys('build/foo-local')
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo').localState('build/foo-local')
def generateBar = bar.task('generateBar').outputs('build/bar')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path, cleanFooLocal.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, TaskOrderSpecs.any(generate.fullPath, cleanFooLocal.fullPath))
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
}
def "destroyer task with a dependency in another build followed by a producer task followed by a destroyer task are run in the correct order"() {
def foo = includedBuild('child').subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def cleanFooLocal = foo.task('cleanFooLocalState').destroys('build/foo-local')
def cleanLocal = rootBuild.task('cleanLocal').dependsOn(cleanFooLocal)
def generateFoo = foo.task('generateFoo').outputs('build/foo').localState('build/foo-local')
def generateBar = bar.task('generateBar').outputs('build/bar')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
// TODO - does not work with CC yet. cleanFoo starts, which blocks generateFoo. However, cleanFooLocalState can start and so runs before generateFoo
// However, the cleanFooLocalState should block because it conflicts with generateFoo
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path, cleanLocal.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, TaskOrderSpecs.any(generate.fullPath, cleanFooLocal.fullPath))
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
}
def "multiple destroyer tasks listed on the command line followed by producers can run concurrently and are executed in the correct order"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo').shouldBlock()
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def cleanBarLocal = bar.task('cleanBarLocalState').destroys('build/bar-local').shouldBlock()
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar').localState('build/bar-local')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
server.start()
writeAllFiles()
expect:
2.times {
server.expectConcurrent(cleanFoo.path, cleanBarLocal.path)
args '--parallel', '--max-workers=2'
succeeds(clean.path, cleanBarLocal.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanBarLocal.fullPath, generateBar.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
}
}
def "a destroyer task finalized by a task in another project will run before producer tasks if ordered first"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanBar = bar.task('cleanBar').destroys('build/bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo').finalizedBy(cleanBar)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
}
def "a destroyer task finalizing both a destroyer and a producer task will run after producer tasks"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanBar = bar.task('cleanBar').destroys('build/bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo').finalizedBy(cleanBar)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar').finalizedBy(cleanBar)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(generateBar.fullPath, TaskOrderSpecs.any(generate.fullPath, cleanBar.fullPath))
}
}
def "a task that is neither a producer nor a destroyer can run concurrently with destroyers"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo').shouldBlock()
def exec = bar.task('exec').shouldBlock()
server.start()
writeAllFiles()
expect:
2.times {
server.expectConcurrent(cleanFoo.path, exec.path)
args '--parallel', '--max-workers=2'
succeeds(cleanFoo.path, exec.path)
}
}
def "destroyers and producers in different projects can run concurrently when they have no dependencies"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo').shouldBlock()
def cleanBar = bar.task('cleanBar').destroys('build/bar')
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar').shouldBlock()
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
server.start()
writeAllFiles()
expect:
2.times {
server.expectConcurrent(cleanFoo.path, generateBar.path)
args '--parallel', '--max-workers=2', '--rerun-tasks' // --rerun-tasks so that tasks are not up-to-date on second invocation
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
}
def "destroyer task that mustRunAfter a task in another project will run before producer tasks when ordered first"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').mustRunAfter(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').outputs('build/foo')
def generateBar = bar.task('generateBar').outputs('build/bar')
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
}
@Issue("https://github.com/gradle/gradle/issues/20195")
def "destroyer task that is a finalizer of a producer task will run after the producer even when ordered first (type: #type)"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar')
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').produces('build/foo', type).finalizedBy(cleanFoo)
def generateBar = bar.task('generateBar').produces('build/bar', type)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(generateFoo.fullPath, cleanFoo.fullPath, clean.fullPath)
result.assertTaskOrder(generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
where:
type << ProductionType.values()
}
@Issue("https://github.com/gradle/gradle/issues/20195")
def "destroyer task that is a finalizer of a producer task and also a dependency will run after the producer even when ordered first (type: #type)"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').produces('build/foo', type).finalizedBy(cleanFoo)
def generateBar = bar.task('generateBar').produces('build/bar', type)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
// cleanFoo must run after generateFoo, as cleanFoo finalizes generateFoo
// cleanFoo must run after generate, as cleanFoo destroys an output produced by generateFoo and consumed by generate
result.assertTaskOrder(generateFoo.fullPath, generate.fullPath, cleanFoo.fullPath, clean.fullPath)
// cleanBar depends on cleanFoo, but cleanFoo must run after generate (per above)
result.assertTaskOrder(generateBar.fullPath, generate.fullPath, cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
}
where:
type << ProductionType.values()
}
@Issue("https://github.com/gradle/gradle/issues/20272")
def "a destroyer task that mustRunAfter a task that does not get executed will run before producer tasks when ordered first (type: #type)"() {
def foo = subproject(':foo')
def bar = subproject(':bar')
def cleanSpecialBar = bar.task('cleanSpecialBar')
def cleanFoo = foo.task('cleanFoo').destroys('build/foo')
def cleanBar = bar.task('cleanBar').destroys('build/bar').dependsOn(cleanFoo).mustRunAfter(cleanSpecialBar)
def clean = rootBuild.task('clean').dependsOn(cleanFoo).dependsOn(cleanBar)
def generateFoo = foo.task('generateFoo').produces('build/foo', type)
def generateBar = bar.task('generateBar').produces('build/bar', type)
def generate = rootBuild.task('generate').dependsOn(generateBar).dependsOn(generateFoo)
writeAllFiles()
expect:
2.times {
args '--parallel', '--max-workers=2'
succeeds(clean.path, generate.path)
result.assertTaskOrder(cleanFoo.fullPath, cleanBar.fullPath, clean.fullPath)
result.assertTaskOrder(cleanFoo.fullPath, generateFoo.fullPath, generate.fullPath)
result.assertTaskOrder(cleanBar.fullPath, generateBar.fullPath, generate.fullPath)
}
where:
type << ProductionType.values()
}
def "build finishes with --continue even when producer task fails"() {
def clean = rootBuild.task('clean').destroys('build')
def compileJava = rootBuild.task('compileJava').outputs('build/classes/java').fail()
def compileGroovy = rootBuild.task('compileGroovy').outputs('build/classes/groovy').dependsOn(compileJava)
def classes = rootBuild.task('classes').dependsOn(compileJava).dependsOn(compileGroovy)
writeAllFiles()
when:
fails(clean.path, classes.path, '--continue')
then:
failure.assertHasDescription("Execution failed for task ':compileJava'.")
failure.assertHasFailures(1)
outputDoesNotContain('Unable to make progress running work.')
}
}