From 3318948ffcbe9c6241c8d8a42e39efdabcaacfd8 Mon Sep 17 00:00:00 2001 From: Volker Leck Date: Thu, 15 Aug 2019 15:47:01 +0200 Subject: [PATCH] Use AtomicInteger for detached configuration name counter Signed-off-by: Volker Leck --- .../configurations/DefaultConfigurationContainer.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java b/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java index e03369cede1b..54c81e906a8c 100644 --- a/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java +++ b/subprojects/dependency-management/src/main/java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java @@ -58,6 +58,7 @@ import java.util.Collection; import java.util.Set; +import java.util.concurrent.atomic.AtomicInteger; public class DefaultConfigurationContainer extends AbstractValidatingNamedDomainObjectContainer implements ConfigurationContainerInternal, ConfigurationsProvider { @@ -79,7 +80,7 @@ public class DefaultConfigurationContainer extends AbstractValidatingNamedDomain private final ProjectStateRegistry projectStateRegistry; private final DocumentationRegistry documentationRegistry; - private int detachedConfigurationDefaultNameCounter = 1; + private final AtomicInteger detachedConfigurationDefaultNameCounter = new AtomicInteger(1); private final Factory resolutionStrategyFactory; private final DefaultRootComponentMetadataBuilder rootComponentMetadataBuilder; private final DomainObjectCollectionFactory domainObjectCollectionFactory; @@ -161,7 +162,7 @@ protected UnknownDomainObjectException createNotFoundException(String name) { @Override public ConfigurationInternal detachedConfiguration(Dependency... dependencies) { - String name = DETACHED_CONFIGURATION_DEFAULT_NAME + detachedConfigurationDefaultNameCounter++; + String name = DETACHED_CONFIGURATION_DEFAULT_NAME + detachedConfigurationDefaultNameCounter.getAndIncrement(); DetachedConfigurationsProvider detachedConfigurationsProvider = new DetachedConfigurationsProvider(); DefaultConfiguration detachedConfiguration = instantiator.newInstance(DefaultConfiguration.class, context, name, detachedConfigurationsProvider, resolver,