Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded Kotlin dependencies should resolve with correct metadata #10745

Closed
eskatos opened this issue Sep 17, 2019 · 1 comment
Closed

Embedded Kotlin dependencies should resolve with correct metadata #10745

eskatos opened this issue Sep 17, 2019 · 1 comment
Assignees
Milestone

Comments

@eskatos
Copy link
Member

eskatos commented Sep 17, 2019

This issue is a follow up to #10697 for which a quick fix #10691 was made for 5.6.3. This issue is about reworking the way dependencies to the embedded Kotlin version are declared in order to prevent issues like #10697 to happen again.

Expected Behavior

Gradle should resolve embedded kotlin dependencies with correct metadata.

Gradle should provide explaining reasons when facing a conflicts with the embedded kotlin version in build scripts classpath.

Current Behavior

The dependency graph of embedded Kotlin dependencies is hardcoded in the Kotlin DSL codebase, making use of a graph of ClientModules instead of proper resolved metadata. This makes it fragile as it needs to be updated each time we upgrade the embedded Kotlin version to reflect a possibly new dependency graph.

Moreover the pinning of those dependencies in the buildscript classpath is done using a dependency resolution rules, which can't provide any explanation to users when facing a conflict.

Context

#10697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant